Skip to content

concat: accept Iterable as keys #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2023
Merged

concat: accept Iterable as keys #639

merged 1 commit into from
Apr 9, 2023

Conversation

fostermaier
Copy link
Contributor

@fostermaier fostermaier commented Apr 8, 2023 •
edited
Loading

Accept Iterable instead of list as keys in pd.concat(). The PR features a basic test with dict values/keys as iterables.

I checked the pandas 1.5 implementation, which casts iterable to list internally
https://github.com/pandas-dev/pandas/blob/996bd1125f21d10e08e2299a4099755f712a2fbf/pandas/core/reshape/concat.py#L508-L509

Dr-Irv
Dr-Irv approved these changes Apr 9, 2023
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fostermaier

@Dr-Irv Dr-Irv merged commit 7fbda1e into pandas-dev:main Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dr-Irv Dr-Irv Dr-Irv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pd.concat: overload for keys=[dict].keys()
2 participants
@fostermaier @Dr-Irv